Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_reader: tighten parsing #437

Closed
wants to merge 1 commit into from
Closed

log_reader: tighten parsing #437

wants to merge 1 commit into from

Conversation

mtrofin
Copy link
Collaborator

@mtrofin mtrofin commented Feb 10, 2025

The log format has a few places where we insert \n for human readability.
They should be checked they are indeed just that character. This will allow us,
in a subsequent PR, to avoid infinitely-blocking cases due to the process
producing the log exiting unexpectedtly, by inserting errors into the reader
to unblock and exit it.

Similarly, checking that the tensor data received matches in size what
was expected.

Refactored a bit the test utility for constructing examples.

The log format has a few places where we insert `\n` for human readability.
They should be checked they are indeed just that character. This will allow us,
in a subsequent PR, to avoid infinitely-blocking cases due to the process
producing the log exiting unexpectedtly, by inserting errors into the reader
to unblock and exit it.

Similarly, checking that the tensor data received matches in size what
was expected.

Refactored a bit the test utility for constructing examples.

commit-id:b1513456
@mtrofin mtrofin closed this Feb 10, 2025
@mtrofin mtrofin deleted the spr/main/b1513456 branch February 10, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant