Add initial shortcut support to menubar for macOS #422
Conversation
Adds the ability to set shortcuts for menu items, using the same format on the Dart side that will be used for Action shorcuts. Currently only the macOS platform implementation uses them. There are some limitations around non-ascii keys, which will be resolved via a full generated keymap once this is folded into Flutter, but common cases are special-cased, and more special-casing can be added as needed by clients. Adds various shortcuts to the testbed app, exercising various modifiers and special cases. Partially addresses google#95
| } | ||
|
|
||
| // Returns the NSEventModifierFlags of |modifiers|, a value from kShortcutKeyModifiers. | ||
| static NSEventModifierFlags KeyEquivalentModifierMaskForModifiers(NSNumber *modifiers) { |
There was a problem hiding this comment.
Do we need to handle the other modifiers here? (NSEventModifierFlagCapsLock, NSEventModifierFlagNumericPad, NSEventModifierFlagHelp, NSEventModifierFlagFunction)
There was a problem hiding this comment.
This code only needs to handle the values that the platform channel can send, which is these four. If you mean do we need to add those on the Dart side too, same comment about actual use case applies to those too.
There was a problem hiding this comment.
My brief perusal of the docs suggested that numpad keys would be handled by a combination of number string and the NSEventModifierFlagNumericPad modifier, as opposed to the numpad keys having separate entries they way they are in LogicalKeyboardKey on the Dart side. It looks like this code can't distinguish between numpad number keys and regular numeric keys. Then there are similar questions about the other things that macOS considers modifiers which aren't in the set of allowed modifiers that this plugin defines.
But anyway, yeah, it's not clear how much people need that.
Adds the ability to set shortcuts for menu items, using the same format
on the Dart side that will be used for Action shorcuts. Currently only
the macOS platform implementation uses them.
There are some limitations around non-ascii keys, which will be resolved
via a full generated keymap once this is folded into Flutter, but common
cases are special-cased, and more special-casing can be added as needed
by clients.
Adds various shortcuts to the testbed app, exercising various modifiers
and special cases.
Partially addresses #95