-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/analysis/passes/printf: extract operation parsing logic into tools/internal/fmtstr #547
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 746a00e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
Message from xxx Lulu: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
This PR (HEAD: 922b6b5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
e1d3c68
to
8fc71b7
Compare
This PR (HEAD: 8fc71b7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: 3e4a92e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from Robert Findley: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-02T14:48:30Z","revision":"6829215837e2878ad9bcf8c2cd5e41864668d917"} Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
Message from Robert Findley: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
c7c9eb6
to
b5bb07b
Compare
This PR (HEAD: b5bb07b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
bf12250
to
3d7747e
Compare
This PR (HEAD: 3d7747e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from Robert Findley: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
8447a0f
to
24677c6
Compare
This PR (HEAD: 24677c6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: 1f760f1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: d107a5e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from Alan Donovan: Patch Set 23: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
This PR (HEAD: cfdd15e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: 5977c77) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: 531b58c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from xxx Lulu: Patch Set 26: (12 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
This PR (HEAD: 9071d05) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from Alan Donovan: Patch Set 27: Code-Review+2 (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
This PR (HEAD: 2e4e80c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: 8e57634) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from xxx Lulu: Patch Set 29: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
This CL made a refactor that extract operation parsing logic into
tools/internal/fmtstr package, so they can be used uniformly by
printf-analyzer for type checking, DocumentHighlight, and future
possibility for SemanticHighlight and rich Hover information with little effort.
Previously, the code responsible for parsing and validating printf-style
format strings was spread inline and blend together in printf.go,
in order to use it for documenthighligt/hover, this CL extends formatState
by encoding posRange and metainfo for every sub-item of a operation
(flag, width, precision, verb), and only expose those field, by that way
callers can compute necessary information from them for various usages.
Updates golang/go#70050