Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(make): restructure makefile for ease of use #21452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuunit
Copy link

@tuunit tuunit commented Jan 22, 2025

Comprehensive Summary of your change

I "stole" a bit of code from the kubebuilder Makefile to have an easier time using make. Furthermore, I took the liberty of restructuring the Makefile a bit. Obviously the copied part is correctly attributed.

Entering make or make help will now yield the following output:
image

For compatibilities sake I didn't change anything about the logic in the Makefile and only restructured it slightly and added the necessary comments and sections for easier usage.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • [-] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@tuunit tuunit requested a review from a team as a code owner January 22, 2025 16:44
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.30%. Comparing base (c8c11b4) to head (877006b).
Report is 374 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21452      +/-   ##
==========================================
+ Coverage   45.36%   46.30%   +0.93%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6429     +380     
- Misses       6983     7116     +133     
- Partials      301      338      +37     
Flag Coverage Δ
unittests 46.30% <ø> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@tuunit tuunit force-pushed the chore/update-makefile-for-ease-of-use branch from 877006b to 10f1d18 Compare January 23, 2025 10:36
@reasonerjt reasonerjt assigned wy65701436 and unassigned chlins Jan 27, 2025
@reasonerjt
Copy link
Contributor

@tuunit
Thanks for the PR, we have some downstream repo that has the dependency on this Makefile so we need some time to double check to evaluate the impact of this chagne.

@wy65701436
Let's see if this aligns with our plan to update the flow.

@tuunit
Copy link
Author

tuunit commented Jan 27, 2025

@tuunit
Thanks for the PR, we have some downstream repo that has the dependency on this Makefile so we need some time to double check to evaluate the impact of this chagne.

@wy65701436
Let's see if this aligns with our plan to update the flow.

I hope and I'm quite certain I didn't introduce any actual change besides visually for a human to interact with the Makefile but obviously my statement shouldn't be trusted blindly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants