Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): remove docker-compose v1 #21449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuunit
Copy link

@tuunit tuunit commented Jan 22, 2025

Motivation

The docker-compose-plugin v2 was released over two years ago and has been available on all major linux distros since docker v20.10.13 in march 2022. V1 has been deprecated since july 2023.

Therefore support for v1 even if it still works shouldn't be continued in my opinion.

Description of changes

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • [-] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@tuunit tuunit requested a review from a team as a code owner January 22, 2025 09:16
@tuunit tuunit changed the title chore(build): deprecate docker-compose v1 chore(build): deprecate / remove docker-compose v1 Jan 22, 2025
@tuunit tuunit changed the title chore(build): deprecate / remove docker-compose v1 chore(build): remove docker-compose v1 Jan 22, 2025
@tuunit tuunit force-pushed the development-cleanup-and-optimization branch 2 times, most recently from d6a4e0e to f1b9127 Compare January 22, 2025 09:19
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.25%. Comparing base (c8c11b4) to head (a6c28db).
Report is 376 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21449      +/-   ##
==========================================
+ Coverage   45.36%   46.25%   +0.88%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6421     +372     
- Misses       6983     7123     +140     
- Partials      301      339      +38     
Flag Coverage Δ
unittests 46.25% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

…d over two years ago and has been available on all major linux distros since docker v20.10.13 in march 2022. v1 has been deprecated since july 2023.

Signed-off-by: Jan Larwig <[email protected]>
@tuunit tuunit force-pushed the development-cleanup-and-optimization branch from f1b9127 to a6c28db Compare January 23, 2025 10:35
@reasonerjt
Copy link
Contributor

@tuunit Thanks for the PR, I agree we should consider dropping it to make the code and test simpler, but we may wanna keep it as is in order not to introduce break change.

@wy65701436 Let's discuss if we wanna remove it in v2.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants