Fix Validation Domain for login command #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vad1mo
requested changes
Dec 3, 2024
|
Hi @Vad1mo, the validation method allow these cases:
The port cannot be less than 0 or greater than 65535 and it validates each label in the domain name for correctness. |
bupd
added
the
Priority: Low
bupd
suggested changes
Dec 28, 2024
There was a problem hiding this comment.
❯ ./harbor-dev login
┃ Server
┃ Server address eg. demo.goharbor.io
┃ > https://127.0.0.4:50
User Name
> lsadkjf
Password
>
Name of Credential
Name of credential to be stored in the harbor config file.
> [email protected]
* invalid domain format: too many colonsthe above is a valid domain
TIP
@Standing-Man, Instead of checking if the domain is valid. check only if its invalid by adding only these rules
Incorrect Domain Names:
http:// (missing domain)
https:// (missing domain)
http://example (missing TLD, not valid)
http://127.0.0.256 (invalid IP, exceeds valid octet range)
http://my_site.local (invalid local domain, underscores are not allowed in domain names)
https://example..com (double period, invalid syntax)
https://.example.com (leading dot in the domain, invalid)
http://-example.com/ (hyphen at the start, invalid)
https://example.c (single character TLD, invalid)
http://192.168.0.999 (invalid IP, octet exceeds range)
Domain Names with Special Characters (Not Valid)
http://example (missing TLD, not valid)
Signed-off-by: Alan Tang <[email protected]>
…0.0 (goharbor#189) Bumps [github.com/charmbracelet/bubbles](https://github.com/charmbracelet/bubbles) from 0.18.0 to 0.20.0. - [Release notes](https://github.com/charmbracelet/bubbles/releases) - [Changelog](https://github.com/charmbracelet/bubbles/blob/master/.goreleaser.yml) - [Commits](charmbracelet/bubbles@v0.18.0...v0.20.0) --- updated-dependencies: - dependency-name: github.com/charmbracelet/bubbles dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Standing-Man
force-pushed
the
validation-domain
branch
from
27e26e4 to
d6daef3
Compare
Signed-off-by: Alan Tang <[email protected]>
|
Hi @bupd, i'm confused about issue #297 and how to reproduce this issue. or just Anyway, i added more restrictions to validate server address and you can try to check if issue #297 solved. |
|
@Standing-Man server address with leading slash result in failed login. We should fix it. |
bupd
suggested changes
Jan 9, 2025
| @@ -39,6 +41,124 @@ func FormatUrl(url string) string { | |||
| return url | |||
| } | |||
|
|
|||
| // ValidateDomain validates subdomain, IP, or top-level domain formats | |||
| func ValidateDomain(domain string) error { | |||
| url := FormatUrl(domain) | |||
There was a problem hiding this comment.
In FormatUrl function. I would suggest adding the removal of leading slash.
There was a problem hiding this comment.
The URL http://registry.bupd.xyz/ is still working for me, so I'm a bit unsure about what might be going wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #269.
Add the Validation function