Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix my grades single layout #2870

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Fix my grades single layout #2870

merged 4 commits into from
Feb 5, 2025

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Feb 4, 2025 •
edited
Loading

Description

Fixes #2869

How has this been tested?

Manually

Screenshots

image

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg requested a review from ideadude as a code owner February 4, 2025 16:35
@brianhogg brianhogg added this to the Next Available Release milestone Feb 4, 2025
ideadude
ideadude approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@ideadude ideadude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

Good to look for anything we have using the llms_before_my_grades_widgets hook, but I'm guessing if it displays odd, the fix would be to the code using the hook vs doing something here.

@brianhogg brianhogg merged commit c298c0c into dev Feb 5, 2025
24 checks passed
@brianhogg brianhogg deleted the fix/my-grades-single-layout branch February 5, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideadude ideadude ideadude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Development
Status: Done
Milestone
Next Available Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhogg @ideadude