Fix translation unloading #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Setting a different language for the User still works. There's more information on translations with Loco translate and custom file locations. This should be fine without unloading the textdomain. https://localise.biz/wordpress/plugin/faqs/custom-folder |
brianhogg
commented
Jan 2, 2025
| @@ -91,7 +89,9 @@ function llms_load_textdomain( $domain, $plugin_dir = null, $language_dir = null | |||
| $plugin_dir = $plugin_dir ? $plugin_dir : LLMS_PLUGIN_DIR; | |||
| $language_dir = $language_dir ? $language_dir : 'languages'; | |||
|
|
|||
| unload_textdomain( $domain ); | |||
| if ( 'lifterlms' !== $domain ) { | |||
There was a problem hiding this comment.
We may want to just remove this completely even for add-ons?
There was a problem hiding this comment.
Yes. Let's remove it completely. Then test and if we don't have the issue in the latest versions of WP, Loco, and Lifter, merge it.
|
Remove completely and do a test with an add-on + loco translate |
…nslate without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was mentioned on a related trac ticket that we should not be unloading the textdomain on
init. This is causing related changes in WP 6.7 to not show the translations if anything uses thelifterlmstextdomain early.I believe the
unload_textdomainwas added to fix a conflict with Loco Translate and saving in a certain location. I'm not able to replicate this, so it may no longer be needed. Restricting to justlifterlmscore for now but we could just remove it for all add-ons too.Refs #2807
How has this been tested?
Manually
Checklist: