Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llmsPostsSelect2 improvements #2806

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Nov 14, 2024

Description

Allowed llmsPostsSelect2 to be called on a group with different data-post-type and other attributes. Also adds data-placeholder support.

Fixes #2805

How has this been tested?

Manually

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg requested a review from ideadude as a code owner November 14, 2024 16:23
@brianhogg brianhogg added this to the Next Available Release milestone Nov 14, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.18% 328/425
🟡 Branches 68.45% 141/206
🟢 Functions 82.93% 68/82
🟡 Lines 76.68% 319/416

Test suite run success

169 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from 0acee44

Copy link
Member

@ideadude ideadude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Working as intended.

@ideadude ideadude merged commit 27631b9 into dev Jan 13, 2025
24 checks passed
@ideadude ideadude deleted the fix/llms-posts-select2-improvements branch January 13, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants