Merge pull request #2838 from gocodebox/dev

Release 7.8.7
gocodebox · Dec 17, 2024 · 2372941 · 2372941
2 parents b7c2463 + 8e60c4d
commit 2372941
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,15 @@
 LifterLMS Changelog
 ===================
 
+v7.8.7 - 2024-12-17
+-------------------
+
+##### Bug Fixes
+
++ Fix translation error during the setup wizard. [#2835](https://github.com/gocodebox/lifterlms/issues/2835)
++ Fixes Pagespeed notice regarding deprecated Javascript event usage. [#2620](https://github.com/gocodebox/lifterlms/issues/2620)
+
+
 v7.8.6 - 2024-12-16
 -------------------
 

diff --git a/assets/js/app/llms-tracking.js b/assets/js/app/llms-tracking.js
@@ -35,7 +35,7 @@ LLMS.Tracking = function( settings ) {
 		self.addEvent( 'page.load' );
 
 		window.addEventListener( 'beforeunload', onBeforeUnload );
-		window.addEventListener( 'unload', onUnload );
+		window.addEventListener( 'pagehide', onUnload );
 
 		document.addEventListener( 'visibilitychange', onVisibilityChange );
 

diff --git a/class-lifterlms.php b/class-lifterlms.php
@@ -34,7 +34,7 @@ final class LifterLMS {
 	 *
 	 * @var string
 	 */
-	public $version = '7.8.6';
+	public $version = '7.8.7';
 
 	/**
 	 * LLMS_Assets instance

diff --git a/includes/admin/class.llms.admin.setup.wizard.php b/includes/admin/class.llms.admin.setup.wizard.php
@@ -118,7 +118,6 @@ public function output_before_importable_course( array $course ): void {
 			</label>
 		</div>
 		<?php
-
 	}
 
 	/**
@@ -155,7 +154,6 @@ protected function get_completed_url( array $course_ids ): string {
 		}
 
 		return admin_url( 'edit.php?post_type=course&orderby=date&order=desc' );
-
 	}
 
 	/**
@@ -181,7 +179,6 @@ protected function save_coupon() {
 		}
 
 		return $ret;
-
 	}
 
 	/**
@@ -194,7 +191,6 @@ protected function save_coupon() {
 	protected function save_pages() {
 
 		return LLMS_Install::create_pages() ? true : new WP_Error( 'llms-setup-pages-save', esc_html__( 'There was an error saving your data, please try again.', 'lifterlms' ) );
-
 	}
 
 	/**
@@ -219,7 +215,6 @@ protected function save_payments(): bool {
 		// phpcs:enable WordPress.Security.NonceVerification.Missing
 
 		return true;
-
 	}
 
 	/**
@@ -251,9 +246,10 @@ protected function save_finish() {
 		}
 
 		return $gen->get_generated_courses();
-
 	}
-
 }
 
-return new LLMS_Admin_Setup_Wizard();
+function llms_load_admin_setup_wizard() {
+	return new LLMS_Admin_Setup_Wizard();
+}
+add_action( 'init', 'llms_load_admin_setup_wizard' );
diff --git a/lifterlms.php b/lifterlms.php
@@ -10,7 +10,7 @@
  * Plugin Name: LifterLMS
  * Plugin URI: https://lifterlms.com/
  * Description: Complete e-learning platform to sell online courses, protect lessons, offer memberships, and quiz students. WP Learning Management System.
- * Version: 7.8.6
+ * Version: 7.8.7
  * Author: LifterLMS
  * Author URI: https://lifterlms.com/
  * Text Domain: lifterlms

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "lifterlms",
-  "version": "7.8.6",
+  "version": "7.8.7",
   "description": "LifterLMS by codeBOX",
   "repository": {
     "type": "git",

diff --git a/packages/llms-e2e-test-utils/src/import-course.js b/packages/llms-e2e-test-utils/src/import-course.js
@@ -40,6 +40,7 @@ export async function importCourse(
 	await clickButton( 'Import' );
 
 	if ( navigate ) {
+		await page.waitForSelector( '.llms-admin-notice.notice-success a' );
 		await clickAndWait( '.llms-admin-notice.notice-success a' );
 	}
 }