Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

fix: PR with TA, TC, TF, or DS ID always fails #330

Merged
merged 3 commits into from
Oct 7, 2021
Merged

fix: PR with TA, TC, TF, or DS ID always fails #330

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9a419e
Update RallyValidate.js
omendrapandey Oct 6, 2021
75b9ca9
Merge pull request #1 from omendrapandey/omendrapandey-patch-1
omendrapandey Oct 6, 2021
68e3294
Update RallyValidate.js
omendrapandey Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/RallyValidate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,7 @@ class RallyValidate {
scope: {
workspace: '/workspace/' + config.rally.workspace
},
fetch: ['FormattedID', 'Name', 'Description', 'ScheduleState', 'Project', 'Connections'],
fetch: ['FormattedID', 'Name', 'Description', 'ScheduleState', 'State', 'Project', 'Connections'],
query: queryUtils.where('FormattedID', '=', githubArtifact.number),
requestOptions: {}
})
Expand All @@ -901,7 +901,7 @@ class RallyValidate {
statusIcon = ':heavy_exclamation_mark:'
} else {
const artifact = queryResponse.Results[0]
status = artifact.ScheduleState
status = artifact.ScheduleState ? artifact.ScheduleState : artifact.State
projectName = artifact.Project._refObjectName
validProject = (config.rally.projects.includes('Any') || config.rally.projects.includes(projectName))
isValid = (config.rally.states.includes(status) && validProject)
Expand Down