Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor directory structure, update _config.yml to match opensource.guide #1283

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ahpook
Copy link
Contributor

@ahpook ahpook commented Jan 8, 2025

This change updates the directory structure of the jekyll site, moving
the language-specific directories under _articles and updating the
front matter / _config.yml to match.

The goal was to clean up the root of the repository and bring the
config in line with that used by the opensource.guide site.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


…guide

This change updates the directory structure of the jekyll site, moving
the language-specific directories under `_articles` and updating the
front matter / `_config.yml` to match.

The goal was to clean up the root of the repository and bring the
config in line with that used by the opensource.guide site.
@Copilot Copilot bot review requested due to automatic review settings January 8, 2025 00:46
@ahpook ahpook requested a review from a team as a code owner January 8, 2025 00:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 48 out of 54 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • _articles/ar/index.html: Language not supported
  • _articles/bg/index.html: Language not supported
  • _articles/bn/index.html: Language not supported
  • _articles/de/index.html: Language not supported
  • _articles/es/index.html: Language not supported
  • _articles/fa/index.html: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM. Very nice.

Non blocking question:

Do we want the index.html, businesses.html and maintainers.html now in the _articles root to be under an en directory or that will break things?

@ahpook
Copy link
Contributor Author

ahpook commented Jan 8, 2025

Do we want the index.html, businesses.html and maintainers.html now in the _articles root to be under an en directory or that will break things?

I think without more extensive surgery they need to live where they are. Based on my primitive understanding, this is because they are the default en / English versions served if the user doesn't pick a different language. Same with the index.html that remains in the repo root. It's like that in github/opensource.guide too...

@jmeridth
Copy link
Member

jmeridth commented Jan 8, 2025

Do we want the index.html, businesses.html and maintainers.html now in the _articles root to be under an en directory or that will break things?

I think without more extensive surgery they need to live where they are. Based on my primitive understanding, this is because they are the default en / English versions served if the user doesn't pick a different language. Same with the index.html that remains in the repo root. It's like that in github/opensource.guide too...

That's what I guessed. Had to ask. Nice clean up and standardize.

@ahpook ahpook merged commit af668fb into main Jan 8, 2025
5 checks passed
@ahpook ahpook deleted the ahpook/refactor-directories branch January 8, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants