Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checking-for-existing-gpg-keys.md #35597

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Conversation

hemashushu
Copy link
Contributor

Add a workaround for the “No valid identities found in this GPG data” error.

Why:

Users may encounter “No valid identities found in this GPG data” error when importing larger GPG public keys. This is because some users have been using GPG for a long time and the public key contains more signature information. The original documentation does not indicate why this error is encountered and does not provide a workaround.

What's being changed (if available, include any code snippets, screenshots, or gifs):

The following paragraph was added:

If you encounter "No valid identities found in this GPG data" error, it may be because the public key you exported is too large or contains useless information, please add GPG option --export-options export-minimal to export again, e.g.: $ gpg --armor --export-options export-minimal --export 3AA5C34371567BD2

Add a workaround for the “No valid identities found in this GPG data” error.
Copy link

welcome bot commented Dec 10, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

👓 How to review these changes

Thank you for your contribution. To review these changes, you can:

  1. Spin up a codespace
  2. Set up a local development environment

A Hubber will need to deploy your changes internally to review.

Table of review links

[!WARNING]
Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
authentication/managing-commit-signature-verification/checking-for-existing-gpg-keys.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server
This table is posted from the Content Changes Table Comment workflow.

🤖 This comment is automatically generated.

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Dec 10, 2024
@nguyenalex836
Copy link
Contributor

@hemashushu Thanks so much for opening a PR! I'll get this triaged for review ✨

@hemashushu
Copy link
Contributor Author

I am providing two public key files for testing:
hippospark.public.zip
one is the original public key, which causes import errors, and the other is the public key after a "gpg clean" operation.
They are both valid public keys and can be verified using the gpg command:

$ gpg --import --import-options show-only hippospark.public.asc 
pub   rsa2048 2013-04-15 [SC] [expires: 2050-03-27]
      AC1F548ADA01B4770A7C5B0E240CA6A5BDAF9022
sub   rsa2048 2013-04-15 [E] [expires: 2050-03-27]
sub   rsa2048 2013-05-14 [S] [expires: 2050-03-27]

@subatoi subatoi added the needs SME This proposal needs review from a subject matter expert label Dec 11, 2024
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

Copy link
Contributor

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Jan 12, 2025
@nguyenalex836 nguyenalex836 removed the SME stale The request for an SME has staled label Jan 13, 2025
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hemashushu, after discussing this internally we'd suggest a minor edit—if you have any specific concerns with this, please let me know, else I'm happy to get this merged. Thank you for your interest in the GitHub docs!

…checking-for-existing-gpg-keys.md

Co-authored-by: Ben Ahmady <[email protected]>
@nguyenalex836 nguyenalex836 added SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Feb 11, 2025
@nguyenalex836
Copy link
Contributor

@hemashushu I went ahead and accepted @subatoi's suggestion, and will get this merged shortly 💛 Thank you so much for contributing to GitHub Docs! ✨

nguyenalex836
nguyenalex836 previously approved these changes Feb 11, 2025
nguyenalex836
nguyenalex836 previously approved these changes Feb 11, 2025
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Feb 11, 2025
Merged via the queue into github:main with commit ce7b11f Feb 11, 2025
44 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants