-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numberdraginput: move under chonk components and cleanup API #86651
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #86651 +/- ##
==========================================
- Coverage 87.83% 87.80% -0.03%
==========================================
Files 9782 9770 -12
Lines 555643 552990 -2653
Branches 21693 21575 -118
==========================================
- Hits 488033 485555 -2478
+ Misses 67215 67064 -151
+ Partials 395 371 -24 |
I managed to figure it out. The step prop required the value to be n * step. I have removed it from the input for now |
The component should use InputGroup to add the trailing items and I've made some API changes that allow us to remove a few handlers and only rely on the native onChange