Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numberdraginput: move under chonk components and cleanup API #86651

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 8, 2025

The component should use InputGroup to add the trailing items and I've made some API changes that allow us to remove a few handlers and only rely on the native onChange

CleanShot 2025-03-07 at 19 42 12@2x

@JonasBa JonasBa requested review from a team as code owners March 8, 2025 00:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 8, 2025
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #86651      +/-   ##
==========================================
- Coverage   87.83%   87.80%   -0.03%     
==========================================
  Files        9782     9770      -12     
  Lines      555643   552990    -2653     
  Branches    21693    21575     -118     
==========================================
- Hits       488033   485555    -2478     
+ Misses      67215    67064     -151     
+ Partials      395      371      -24     

@JonasBa
Copy link
Member Author

JonasBa commented Mar 9, 2025

@evanpurkhiser any ideas why this might break our forms? I tested manually and the form still works as it used to (both creating new alerts and editing existing ones), but it seems the tests are busted.

I managed to figure it out. The step prop required the value to be n * step. I have removed it from the input for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants