feat(flags): add "All Feature Flags" distributions drawer #86359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Mar 5, 2025
scttcper
reviewed
Mar 5, 2025
static/app/components/events/featureFlags/featureFlagDistributions.tsx
Outdated
Show resolved
Hide resolved
Bundle ReportChanges will decrease total bundle size by 32.51kB (-0.08%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
|
ryan953
reviewed
Mar 5, 2025
aliu39
added a commit
that referenced
this pull request
Mar 5, 2025
scttcper
reviewed
Mar 5, 2025
static/app/components/events/featureFlags/featureFlagDistributions.tsx
Outdated
Show resolved
Hide resolved
philipphofmann
pushed a commit
that referenced
this pull request
Mar 6, 2025
scttcper
reviewed
Mar 6, 2025
static/app/components/events/featureFlags/featureFlagDistributions.tsx
Outdated
Show resolved
Hide resolved
|
I'll be updating this PR to move the flag distributions/segmented control to the tags drawer, based on https://www.figma.com/design/p2DOzd1RwAHQbq0v6KaYmF/Issue-Details?node-id=6679-14751&t=Oev4B6ZDGF0cxCqg-11. The flags table and "view more flags" should be event-level data, same with the "View all issue tags" in the tags section (which we plan to remove). 
Going forwrad tags and flags distributions will be accessible from this "View all tags" link near the top of issue details. (renaming to "View all tags and flags")
|
aliu39
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #86359 +/- ##
==========================================
- Coverage 87.83% 87.77% -0.06%
==========================================
Files 9782 9776 -6
Lines 555643 553717 -1926
Branches 21693 21690 -3
==========================================
- Hits 488033 486034 -1999
- Misses 67215 67288 +73
Partials 395 395 |
ryan953
reviewed
Mar 9, 2025
static/app/views/issueDetails/groupFeatureFlags/groupFeatureFlagsDrawer.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/getsentry/team-replay/issues/550
(Button to open drawer is outdated, see #86359 (comment))
https://github.com/user-attachments/assets/f678a973-95dc-4f47-8ef8-f8d3ade33549
tagDistribution.tsxso the prefetch (from hovering over a card) and link to all values (from clicking a card) behavior is extracted into a wrapper component, which we'll skip for flags.