-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options.ignoredErrors
accepting String and Regex
#4083
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
00c8eeb | 415.32 ms | 428.08 ms | 12.76 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
00c8eeb | 1.70 MiB | 2.36 MiB | 671.98 KiB |
Previous results on branch: feat/ignore-exceptions
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
27b404c | 402.96 ms | 465.55 ms | 62.59 ms |
8b85eaa | 438.47 ms | 462.70 ms | 24.23 ms |
8011314 | 398.27 ms | 475.16 ms | 76.88 ms |
d7c436a | 447.47 ms | 513.85 ms | 66.38 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
27b404c | 1.65 MiB | 2.31 MiB | 678.18 KiB |
8b85eaa | 1.65 MiB | 2.31 MiB | 677.69 KiB |
8011314 | 1.65 MiB | 2.31 MiB | 677.69 KiB |
d7c436a | 1.65 MiB | 2.31 MiB | 677.88 KiB |
226f075
to
82b9faf
Compare
…eral possible messages as in the JS SDK and not on only on the Exception class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good already, we should agree on an order of evaluation for the filtering and keep it consistent across events being checked.
options.ignoreExceptions
accepting String and Regexoptions.ignoredErrors
accepting String and Regex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👏 LGTM!
📜 Description
Adds an option
ignoredErrors
(calledignoreErrors
in other SDKs) to ignore Errors matching a certain String or Regex💡 Motivation and Context
Closes #3471
💚 How did you test it?
Unit tests for Client, Options and ExternalOptions
📝 Checklist
sendDefaultPII
is enabled.