Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MAUI samples config - enable deploy #3665

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

bricefriha
Copy link
Contributor

@bricefriha bricefriha commented Oct 8, 2024

Enabling deploy in the configuration for the MAUI sample allows the app to be run on VS2022 (on Windows).
image

see: here

Note

Linux and Mac, in my experience, are not affected.

#skip-changelog

@bricefriha
Copy link
Contributor Author

Do we have to update the change log for this? Considering it's not something that would change the user experience

@jamescrosswell
Copy link
Collaborator

Do we have to update the change log for this? Considering it's not something that would change the user experience

Nah I think we can skip the changelog on this one.

@bitsandfoxes
Copy link
Contributor

To avoid Danger being annoying you can add #skip-changelog to your PR description.

@bruno-garcia
Copy link
Member

To avoid Danger being annoying you can add #skip-changelog to your PR description.

Use #skip-changelog if your change doesn't have any user-facing or user-impactful change. For example this PR. Otherwise please add an entry to the changelog that **helps users understand what's in the change. If it's worth them bumping or if they can or should wait for some reason"

@bruno-garcia bruno-garcia enabled auto-merge (squash) October 9, 2024 12:39
@bruno-garcia bruno-garcia merged commit a249a83 into main Oct 9, 2024
21 of 22 checks passed
@bruno-garcia bruno-garcia deleted the fix/maui_sample_deploy_config branch October 9, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants