build: Use Accept:application/vnd.github.VERSION.sha to get the latest sha of sentry-api-schema repo #9106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t sha of sentry-api-schema repo
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
ryan953
force-pushed
the
ryan953/fix-bump-api-schema-script-2
branch
from
1fc3f6c to
c2d80bd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is following up on: #9086 (reverted in #9102)
The reason that initial attempt didn't work isn't clear to me, i think it's because the api response included funky data (sometimes) that would cause two sha's to be returned instead of the one that we expected. I'm not 100% sure exactly, but the logs for failing runs clearly show unexpected things happened like
Switched to a new branch 'bot/bump-api-schema-to-'where no sha is suffixed to the branch name.So this takes a different approach: ask for the sha only, and skip all the rest of the parsing business.