Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mobile onboarding feature snippets #12956

Merged
merged 10 commits into from
Mar 7, 2025
Merged

fix: Mobile onboarding feature snippets #12956

merged 10 commits into from
Mar 7, 2025

Conversation

kahest
Copy link
Member

@kahest kahest commented Mar 7, 2025

DESCRIBE YOUR PR

fixes various issues in Mobile onboarding snippets:

  • all platforms: reordered all snippets so that the new sendDefaultPii section is the first after DSN, above all features, to reduce the amount of animation when switching between features
  • Apple: fixed line configs for features, changed profiling section in app conformer snippet to start/stop profiler
  • Flutter: added missing sendDefaultPii section in the custom zone snippets
  • Capacitor: fixed line configs for features

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 2:05pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2025 2:05pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2025 2:05pm

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@smeubank smeubank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to reduce the amount of animation when switching between features

I like the attention to detail :) 🚀

kahest added 2 commits March 7, 2025 13:34
# Conflicts:
#	docs/platforms/dart/guides/flutter/index.mdx
#	docs/platforms/dart/guides/flutter/manual-setup.mdx
Copy link

codecov bot commented Mar 7, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.55MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.18kB -0.0%
static/chunks/3319-*.js -3 bytes 393.41kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/2m9TOGAHjuJwZFENIgib2/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/2m9TOGAHjuJwZFENIgib2/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/fcqRupxtqFsczWNFKYOZX/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/fcqRupxtqFsczWNFKYOZX/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.57MB -0.0%
../instrumentation.js -3 bytes 904.32kB -0.0%
9523.js -3 bytes 880.37kB -0.0%

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capacitor docs are good!

@kahest kahest merged commit 44fea31 into master Mar 7, 2025
11 checks passed
@kahest kahest deleted the kahest/fix-snippets branch March 7, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants