Flutter as framework of Dart #12866
Merged
Flutter as framework of Dart #12866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves all the files of Flutter to be under Dart, same as JavaScript and Python and other language to framework relationships. After this is merged. I will begin looking at first updating all the links in product and static-pages to respect these new redirect links. Potentially blogs aswell. But then importantly and funcitonally, I want to look at ensuring that feature which the Flutter SDK inherits from the Dart SDK and any example in the other direction, are properly show in the docs. For example Dio integration is not seen in flutter.
flutter icon should display for flutter on main page and side bar
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 2.52kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
26 tasks
smeubank
added a commit
to getsentry/sentry
that referenced
this pull request
Feb 27, 2025
getsentry/sentry-docs#12866 this PR is just to prepare for the changes we might apply on docs
would otherwise need to update types or some other strangeness, and the config as is, is rather extensive
kahest
reviewed
Feb 28, 2025
remove middleware redirects and put the wildcard impl in redirects
chargome
reviewed
Mar 6, 2025
| @@ -12,7 +12,7 @@ | |||
| # /src/wizard/android/ @getsentry/team-mobile-core | |||
| # /src/platforms/apple/ @getsentry/team-mobile-core | |||
| # /src/wizard/apple/ @getsentry/team-mobile-core | |||
| # /src/platforms/flutter/ @getsentry/team-mobile-cross-platform | |||
| # /src/platforms/dart/guides/flutter/ @getsentry/team-mobile-cross-platform | |||
There was a problem hiding this comment.
this actually has no effect since the path is not correct for any of these, but we'll fix that in a separate pr
kahest
requested changes
Mar 6, 2025
There was a problem hiding this comment.
overall lgtm, but I think the Mobile Vitals page was merged incorrectly, see comment (also fyi @markushi)
when I open this page locally, I also get the same error as the Vercel build
Error occurred prerendering page "/product/insights/mobile". Read more: https://nextjs.org/docs/messages/prerender-error
Error: Build failed with 1 error:
_mdx_bundler_entry_point-4b598cda-599a-4961-9447-0e9106cb4fe2.mdx:0:0: ERROR: [plugin: @mdx-js/esbuild] Cannot process MDX file with esbuild
at failureErrorWithLog (/vercel/path0/node_modules/esbuild/lib/main.js:1477:15)
it is redirecting as if it is in flutter context, but it's not a more explicit link hopefully resolves this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all the files of Flutter to be under Dart, same as JavaScript and Python and other language to framework relationships.
After this is merged. I will begin looking at first updating all the links in the following, to respect these new redirect links.
Functionally in the UI, this PR only really removes Flutter as a platform in the landing page and side bar. It is a subitem under Dart
But then importantly and functionally, I want to look at ensuring that features which the Flutter SDK inherits from the Dart SDK, and any examples in the other direction, are properly show in the docs. For example Dio integration is not seen in flutter.