Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): fix logo for actix-web #12793

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix(rust): fix logo for actix-web #12793

merged 1 commit into from
Feb 21, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Feb 20, 2025

DESCRIBE YOUR PR

Fixes the logo to the correct one for actix-web, which was previously showing up with the Rust logo instead because rust-actix didn't match the platform name.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 5:59pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 5:59pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Feb 20, 2025 5:59pm

Copy link

codecov bot commented Feb 20, 2025

Bundle Report

Changes will decrease total bundle size by 3 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB -1 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -2 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
1054.js 8 bytes 81.43kB 0.01%

Files in 1054.js:

  • ./src/components/platformIcon.tsx → Total Size: 35.2kB

  • ./src/components/platformIcon.tsx → Total Size: 35.2kB

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/chunks/4744-*.js 4 bytes 42.13kB 0.01%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/FWozJ0TzTDC8hPMl3ssEi/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/FWozJ0TzTDC8hPMl3ssEi/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/kdSpaPexceeLxvb677q9o/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/kdSpaPexceeLxvb677q9o/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/4744-*.js:

  • ./src/components/platformIcon.tsx → Total Size: 35.27kB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM

l side note:
Currently looks like this:
Screenshot 2025-02-21 at 07 33 47

Should we use a different version of the icon?

@lcian lcian merged commit 00874c4 into master Feb 21, 2025
13 checks passed
@lcian lcian deleted the lcian/fix/actix-logo branch February 21, 2025 06:35
@lcian
Copy link
Member Author

lcian commented Feb 21, 2025

Fix LGTM

l side note: Currently looks like this: Screenshot 2025-02-21 at 07 33 47

Should we use a different version of the icon?

Good catch, looks like the homepage https://docs.sentry.io/ uses different icon versions than the platform page.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants