Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(insights): Update docs for upcoming mobile screens GA #12366

Merged
merged 11 commits into from
Mar 4, 2025

Conversation

markushi
Copy link
Member

@markushi markushi commented Jan 16, 2025

This is mostly a restructuring of existing content, updating some wordings and screenshots to the the latest changes for the upcoming "Mobile Screens" insights module.

Fixes getsentry/sentry#81566
Fixes getsentry/sentry#81567
Fixes getsentry/sentry#84163

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): 01/17/2024
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@markushi markushi requested a review from bcoe January 16, 2025 08:08
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 8:10am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 8:10am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 8:10am

Copy link

codecov bot commented Jan 16, 2025

Bundle Report

Changes will increase total bundle size by 651 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.19MB 657 bytes (0.01%) ⬆️
sentry-docs-client-array-push 9.38MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.46MB -0.0%
../instrumentation.js -3 bytes 791.26kB -0.0%
9523.js -3 bytes 767.46kB -0.0%
../app/[[...path]]/page.js.nft.json 222 bytes 382.43kB 0.06%
../app/platform-redirect/page.js.nft.json 222 bytes 382.34kB 0.06%
../app/sitemap.xml/route.js.nft.json 222 bytes 380.31kB 0.06%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.04kB -0.0%
static/chunks/4028-*.js -3 bytes 393.29kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/fjvcMufDVxJL1xjOz53jP/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/fjvcMufDVxJL1xjOz53jP/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/luW4lDf2KDW1FNyiHxn2S/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/luW4lDf2KDW1FNyiHxn2S/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating - gave this a quick first pass and looks good already 👍

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this big update! Added a few suggestions, most importantly addressing a broken link. Besides that, looks good to me 🤠

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor nits. Independently, I had lost track in the shuffle that the plan was to see Mobile Screens to completion, vs., adding docs for Screen Rendering and calling it GA.

The web-vitals-like landing page looks lovely and I think is great work. We should just do a tiny bit more footwork before we go GA (I'll bring to chat, I don't see any major blockers).

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @markushi. LGTM, with two minor suggestions.

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left small suggestions, otherwise lgtm 🚢

@markushi markushi merged commit c371429 into master Mar 4, 2025
13 checks passed
@markushi markushi deleted the markushi/chore/update-docs-for-mobile-screens branch March 4, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants