Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(js-sdk): use js transport #2563

Merged
merged 29 commits into from
Jan 13, 2025
Merged

feat(js-sdk): use js transport #2563

merged 29 commits into from
Jan 13, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jan 8, 2025 •
edited
Loading

📜 Description

Uses js sendEnvelope from the JS SDK transport

💡 Motivation and Context

Part of JS SDK Integration

💚 How did you test it?

Unit test, Integration test, manual

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@buenaflor buenaflor changed the base branch from main to feat/js-sdk-integration January 8, 2025 15:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a781aff

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (be08651) to head (a781aff).
Report is 86 commits behind head on feat/js-sdk-integration.

Files with missing lines Patch % Lines
flutter/lib/src/native/sentry_native_channel.dart 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##           feat/js-sdk-integration    #2563       +/-   ##
============================================================
+ Coverage                    70.98%   87.09%   +16.10%     
============================================================
  Files                           17      265      +248     
  Lines                          579     9258     +8679     
============================================================
+ Hits                           411     8063     +7652     
- Misses                         168     1195     +1027

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

denrase
denrase requested changes Jan 9, 2025
View reviewed changes
flutter/lib/src/native/c/sentry_native.dart Outdated Show resolved Hide resolved
flutter/lib/src/sentry_flutter.dart Show resolved Hide resolved
flutter/lib/src/web/sentry_web.dart Show resolved Hide resolved
@buenaflor buenaflor marked this pull request as ready for review January 13, 2025 09:11
@buenaflor
Copy link
Contributor Author

@denrase could you have another look pls, I use the encoded object directly, the only thing I kept now after changes is the new method to captureEnvelopes

denrase
denrase approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor thing/question about the error cathcing method.

flutter/lib/src/web/sentry_web.dart Outdated Show resolved Hide resolved
flutter/lib/src/web/sentry_web.dart Outdated Show resolved Hide resolved
@buenaflor buenaflor merged commit 9c5e6aa into feat/js-sdk-integration Jan 13, 2025
146 checks passed
@buenaflor buenaflor deleted the feat/js-send-envelopes branch January 13, 2025 14:43
@buenaflor buenaflor mentioned this pull request Jan 13, 2025
Merged
buenaflor added a commit that referenced this pull request Jan 14, 2025
@buenaflor
v0 js sdk integration (#2572)
f27eaee 
* feat(js-sdk): add script loader to set up Sentry Javascript SDK (#2406)

* update

* update

* updaet

* Update sentry_js_sdk_version.dart

* temporary ci change

* fix test

* fix compilation

* fix compilation

* fix

* fix test

* update

* fix test

* fix test

* update

* update

* update

* fix analyze

* update

* update

* update validation

* update

* update

* update

* rethrow on automated test mode

* update rethrow

* update

* update tests

* update appending

* update web

* add trusted types and add tests

* formatting

* update comment

* add as browser test

* fix min_version

* fix warnings

* add another test file

* update

* update comment

* try out web integration test

* update

* use ubuntu latest for web

* see if it runs

* update

* fix job

* fix job

* run chromedriver in background

* run correct port

* update

* update

* setup chrome action

* update

* run chrome first

* try

* update

* update

* remove file

* update

* update

* fix tests

* update

* update docs and test cases

* add todo

* update

* update

* add doc and fix tests

* update tests

* update

* update

* Update web_sdk_test.dart

* add test with automatedTestMode false

* update

* remove debug

* remove fn

* update restore flutter onError

* fix analyze

* Update flutter.yml

* feat: sentry web api (#2489)

* update

* update

* update test

* update

* update

* update

* update

* update doc

* update

* update

* update

* update test

* update

* update tests

* use tryCatchSync

* formatting

* fix sentry_flutter_test

* fix analyze

* update test

* fix tests

* update test

* update test

* update scripts

* ignore sentry_web in coverage

* update test

* temporary

* update

* test

* update tests

* update test with mocks

* fix analyze

* update

* update names

* fix test

* update

* update integration

* update comment

* update flutter enricher

* update test

* update

* update flag name

* update

* update binding creation condition

* update

* update integration test

* fix tests

* feat(js-sdk): enable global error handler and dedupe integration (#2566)

* add default integrations

* fix integration test

* feat(js-sdk): use js transport (#2563)

* add envelope sending

* add test

* add test

* update message

* update payload api

* update

* update payload api

* revert hasNativeIntegration

* update

* dont remove scope observer

* fix integration test

* cleanup

* update test

* update test

* cleanup integration test

* improve envelope capturing

* clean up

* fix analyze

* fix tests

* update

* formatting

* fix integration test

* use buckets

* fix log string

* update mocks

* update mocks

* process succeessful envelope items

* update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denrase denrase denrase approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buenaflor @denrase