Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redash upgrade instructions and compose file #698

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

mirkan1
Copy link
Contributor

@mirkan1 mirkan1 commented Apr 28, 2024

No description provided.

@justinclift
Copy link
Member

Super cool, thanks. Eyeballing this, it seems pretty straight forward and looks correct. 😄

@justinclift justinclift merged commit 452e98d into getredash:master Apr 29, 2024
3 checks passed
@lucydodo
Copy link
Member

Screenshot 2024-04-29 at 15 35 42
I think you're forgetting to squash the commits. Why don't we revert the commit, squash it, and push it again?

@mirkan1
Copy link
Contributor Author

mirkan1 commented Apr 29, 2024

To be honest, I am not sure how that would work at this point

@justinclift
Copy link
Member

Why don't we revert the commit, squash it, and push it again?

Oops, I totally forgot. Um, do you want to fix it? If you can't be bothered, I can get it done. 😄

@justinclift
Copy link
Member

@mirkan1 It's not super hard to fix. It just needs a bit of manual mucking around to merge those into a single commit before force pushing it back to the repo. 😄

@lucydodo
Copy link
Member

lucydodo commented Apr 29, 2024

@mirkan1 Sorry, I forgot to mention @justinclift, we can take care of that ourselves.
@justinclift I'll do it. :) Fixed via 22ee55d :)

@justinclift
Copy link
Member

@lucydodo Cool, thanks heaps. I wouldn't have even noticed for ages, and by then we'd probably have added more stuff. 😄

@mirkan1 mirkan1 deleted the develop branch April 29, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants