Fix errors in webex alert destination. Add formatting support for QUERY_RESULT_TABLE. #7296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webex send ERROR:: Object of type set is not JSON serializable Signed-off-by: Matt Nelson <[email protected]>
Signed-off-by: Matt Nelson <[email protected]>
Signed-off-by: Matt Nelson <[email protected]>
Signed-off-by: Matt Nelson <[email protected]>
metheos
changed the title
Signed-off-by: Matt Nelson <[email protected]>
Signed-off-by: Matt Nelson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7296 +/- ##
==========================================
+ Coverage 64.01% 64.06% +0.04%
==========================================
Files 163 163
Lines 13410 13430 +20
Branches 1905 1909 +4
==========================================
+ Hits 8585 8604 +19
- Misses 4490 4491 +1
Partials 335 335
|
ensure blank entries are handled for room IDs and person emails. ensure that the API is not called when no valid destinations are provided. ensure proper attachment formatting for alerts containing 2D arrays. Signed-off-by: Matt Nelson <[email protected]>
This commit introduces a new test case to verify that the Webex notification function correctly handles a 1D array input in the alert body. The test ensures that the expected payload is constructed properly and that the requests.post method is called with the correct parameters. Signed-off-by: Matt Nelson <[email protected]>
arikfr
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Nelson [email protected]
What type of PR is this?
Description
Fix errors regarding text values being detected as 'set' on post to webex API throwing JSON error "Object of type set is not JSON serializable"
Don't try to send to empty destinations.
Adds support for formatting QUERY_RESULT_TABLE as card in the webex message. (See screenshot)
How is this tested?
Existing Tests in test_destinations extended for coverage of new scenarios
Mobile & Desktop Screenshots/Recordings (if there are UI changes)