Chunk deleted files into batches #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 has a batch delete limit of 1000 files. The PR introduces chunking `keysToDelete` into batches of 1000 files to bypass the limitation.
|
Thanks! It seems the build is failing, but I don't think it's related to the PR 🤔 |
|
@mnapoli yeah, it seems that the workflow is broken |
|
Have you been able to test these changes against AWS and see if they work? I'm happy to merge if this was tested manually. |
|
@mnapoli yeah, we run this in production |
|
Got it thanks! |
This was referenced Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 has a batch delete limit of 1000 files.
The PR introduces chunking
keysToDeleteinto batches of 1000 files to bypass the limitation.