BUG: Fix timezone names #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect time zone identifier from the tz database.
…ntifier from the tz database.
|
Not sure what the problem with the Pull Request Labeler action/check is. |
|
Please ignore the labeler for now, just needs to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I noticed that some calendars use an incorrect or dubious timezone info. Specifically, XETR and XFRA use
ZoneInfo('CET')and XNZE usesZoneInfo('NZ').Re XETR and XFRA, I think it's incorrect to use CET since this is a standard time, i.e. a fixed offset (+01:00) to UTC. But since Germany observes summer time (CEST = +02:00), the correct timezone to use would be
ZoneInfo('Europe/Berlin').For XNZE, I'm not even sure what the definition of
ZoneInfo('NZ') is, butZoneInfo('Pacific/Auckland')` seems to be the correct time zone to use.