feat: add ability to run local browsers without specified browserVersion #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
force-pushed
the
TESTPLANE-386.latest_local_browser
branch
2 times, most recently
from
189f8f1 to
3ee0266
Compare
KuznetsovRoman
commented
Dec 26, 2024
Comment on lines
+80
to
+95
| export const resolveLatestChromeVersion = _.memoize(async (force = false): Promise<string> => { | ||
| if (!force) { | ||
| const platform = getBrowserPlatform(); | ||
| const existingLocallyBrowserVersion = registry.getMatchedBrowserVersion(BrowserName.CHROME, platform); | ||
|
|
||
| if (existingLocallyBrowserVersion) { | ||
| return existingLocallyBrowserVersion; | ||
| } | ||
| } | ||
|
|
||
| return retryFetch(CHROME_FOR_TESTING_LATEST_STABLE_API_URL) | ||
| .then(res => res.text()) | ||
| .catch(() => { | ||
| throw new Error("Couldn't resolve latest chrome version"); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Достаем либо "какую-то локально имеющуюся".
Если "какой-то" локально нет, ходим в АПИ-шку и достаем последнюю оттуда.
Также всегда ходим в АПИ-шку при явном вызове install-deps (force === true, если вызвали npx testplane install-deps)
Comment on lines
+3
to
+11
| const CHROME_FOR_TESTING_VERSIONS_API_URL = "https://googlechromelabs.github.io/chrome-for-testing"; | ||
| export const CHROME_FOR_TESTING_MILESTONES_API_URL = `${CHROME_FOR_TESTING_VERSIONS_API_URL}/latest-versions-per-milestone.json`; | ||
| export const CHROME_FOR_TESTING_LATEST_STABLE_API_URL = `${CHROME_FOR_TESTING_VERSIONS_API_URL}/LATEST_RELEASE_STABLE`; | ||
|
|
||
| export const GECKODRIVER_CARGO_TOML = "https://raw.githubusercontent.com/mozilla/geckodriver/release/Cargo.toml"; | ||
|
|
||
| const FIREFOX_VERSIONS_VERSIONS_API_URL = "https://product-details.mozilla.org/1.0"; | ||
| export const FIREFOX_VERSIONS_ALL_VERSIONS_API_URL = `${FIREFOX_VERSIONS_VERSIONS_API_URL}/firefox.json`; | ||
| export const FIREFOX_VERSIONS_LATEST_VERSIONS_API_URL = `${FIREFOX_VERSIONS_VERSIONS_API_URL}/firefox_versions.json`; |
There was a problem hiding this comment.
Тут использую еще пару ручек тех же самых хостов
Comment on lines
+49
to
+67
| export const resolveEdgeVersion = _.once(async () => { | ||
| const platform = getBrowserPlatform(); | ||
|
|
||
| switch (platform) { | ||
| case BrowserPlatform.LINUX: | ||
| return resolveLinuxEdgeVersion(); | ||
|
|
||
| case BrowserPlatform.WIN32: | ||
| case BrowserPlatform.WIN64: | ||
| return resolveWindowsEdgeVersion(); | ||
|
|
||
| case BrowserPlatform.MAC: | ||
| case BrowserPlatform.MAC_ARM: | ||
| return resolveMacEdgeVersion(); | ||
|
|
||
| default: | ||
| throw new Error(`Unsupported platform: "${platform}"`); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Тут вычисляем, какая версия edge локально установлена на компьютере
Comment on lines
+71
to
+87
| export const resolveLatestFirefoxVersion = _.memoize(async (force = false): Promise<string> => { | ||
| if (!force) { | ||
| const platform = getBrowserPlatform(); | ||
| const existingLocallyBrowserVersion = registry.getMatchedBrowserVersion(BrowserName.FIREFOX, platform); | ||
|
|
||
| if (existingLocallyBrowserVersion) { | ||
| return existingLocallyBrowserVersion; | ||
| } | ||
| } | ||
|
|
||
| return retryFetch(FIREFOX_VERSIONS_LATEST_VERSIONS_API_URL) | ||
| .then(res => res.json()) | ||
| .then(({ LATEST_FIREFOX_VERSION }) => LATEST_FIREFOX_VERSION) | ||
| .catch(() => { | ||
| throw new Error("Couldn't resolve latest firefox version"); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Аналогично "chrome"
Comment on lines
+4
to
+24
| export const resolveSafariVersion = _.once( | ||
| () => | ||
| new Promise<string>((resolve, reject) => { | ||
| const getSafariVersionError = new Error("Couldn't retrive safari version."); | ||
|
|
||
| exec("mdls -name kMDItemVersion /Applications/Safari.app", (err, stdout) => { | ||
| if (err) { | ||
| reject(getSafariVersionError); | ||
| return; | ||
| } | ||
|
|
||
| const regExpResult = /kMDItemVersion = "(.*)"/.exec(stdout); | ||
|
|
||
| if (regExpResult && regExpResult[1]) { | ||
| resolve(regExpResult[1]); | ||
| } else { | ||
| reject(getSafariVersionError); | ||
| } | ||
| }); | ||
| }), | ||
| ); |
There was a problem hiding this comment.
Аналогично edge: достаем локально имеющуюся версию safari
KuznetsovRoman
force-pushed
the
TESTPLANE-386.latest_local_browser
branch
from
3ee0266 to
3291b53
Compare
DudaGod
approved these changes
Jan 10, 2025
KuznetsovRoman
force-pushed
the
TESTPLANE-386.latest_local_browser
branch
2 times, most recently
from
f665bb1 to
63f96ba
Compare
KuznetsovRoman
force-pushed
the
TESTPLANE-386.latest_local_browser
branch
from
63f96ba to
7827fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.