Add DEP-06: Immutable ETCD Backups #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
seshachalam-yv
changed the title
DEP-06: Immutable ETCD Backups
seshachalam-yv
changed the title
DEP-06: Immutable ETCD BackupsDEP-06: Immutable ETCD Backups
seshachalam-yv
changed the title
DEP-06: Immutable ETCD Backups
ishan16696
requested changes
Oct 9, 2024
gardener-robot-ci-3
added
reviewed/ok-to-test
ashwani2k
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Thanks @seshachalam-yv @ishan16696 @renormalize for the proposal.
It captures thing well, but I've put some open points esp. on the structure as well some details esp. as it addresses design considerations.
gardener-robot
added
size/l
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
anveshreddy18
approved these changes
Feb 5, 2025
shreyas-s-rao
requested changes
Feb 5, 2025
There was a problem hiding this comment.
@seshachalam-yv thanks a lot for making the requested changes! Just one nit, but overall LGTM!
Co-authored-by: Shreyas Rao <[email protected]>
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
unmarshall
requested changes
Feb 6, 2025
Co-authored-by: Madhav Bhargava <[email protected]>
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
…utabilityTask when immutability configuration is removed from etcd.spec.backup.store
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
/retest |
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area backup
/area disaster-recovery
/area security
/area compliance
/area storage
/kind enhancement
What this PR does / why we need it:
This PR adds
DEP-06: Immutable ETCD Backups. The proposal aims to enhance the reliability and integrity of ETCD backups in ETCD Druid by introducing immutable backups. By leveraging cloud provider features that support a write-once-read-many (WORM) model, this approach prevents unauthorized modifications to backup data, ensuring that backups remain available and intact for restoration.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: