-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a minimal matrix object implementation #5152
base: master
Are you sure you want to change the base?
Conversation
Feedback on whether or not to have this in the release notes is welcome. |
This code seems in a basically good state. Obviously tests for it, and using it, are important but can be part of future work. Only one thought I have now, before this is merged -- given that most people don't read manuals, I worry that people might see As it might get slower (and less useful) as tests are added to it, I might give it a more explicit name, like |
64dabf8
to
837a7af
Compare
@ChrisJefferson Thanks for the suggestion. I didn't think of that way to understand the name but it is sensible to make it absolutely clear in the name that it is not intended for usage in computations. I chose the name |
Hint: if you replace |
9824dbc
to
4943105
Compare
228a998
to
83a5f76
Compare
83a5f76
to
54813ed
Compare
This PR adds a matrix object
IsMinimalMatrixRep
. Internally it represents the matrix as a flat list in row-major form. It only the required methods.This is intended to be used as a minimal example and in order to test code, in particular the generic methods.
Regarding tests, if nothing obvious is wrong I'd like to merge this asap and then use it with the new test suite. Any errors could be fixed then.
This resolves Issue #5142.