-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change input format of plotdexseq tool from rdata to rds #6709
Conversation
The dexseq tool outputs an rds file. The input to this tool should be an rds file, not rdata. |
@pavanvidem is it really on harddrive an RDS or is it a rdata? |
technically, it should be an rds file because there is only one object in it. |
please don't merge yet. The plot margins need to be adjusted. |
ready from my side |
I don't understand why the linting failed. There is also a biotools entry: https://bio.tools/dexseq |
You also use readRDS https://www.rdocumentation.org/packages/base/versions/3.6.2/topics/readRDS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools/dexseq/macros.xml
Outdated
@@ -1,7 +1,7 @@ | |||
<macros> | |||
<token name="@TOOL_VERSION@">1.48.0</token> | |||
<token name="@VERSION_SUFFIX@">0</token> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to bump.
I prefer bumbing all tools in a suite .. otherwise it becomes unmaintainable. Nobody checks if all tools use the macro on update...
FOR CONTRIBUTOR: