Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change input format of plotdexseq tool from rdata to rds #6709

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

pavanvidem
Copy link
Member

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@pavanvidem
Copy link
Member Author

The dexseq tool outputs an rds file. The input to this tool should be an rds file, not rdata.

@bgruening
Copy link
Member

@pavanvidem is it really on harddrive an RDS or is it a rdata?

@pavanvidem
Copy link
Member Author

technically, it should be an rds file because there is only one object in it.

@pavanvidem
Copy link
Member Author

please don't merge yet. The plot margins need to be adjusted.

@pavanvidem
Copy link
Member Author

ready from my side

@pavanvidem
Copy link
Member Author

I don't understand why the linting failed. There is also a biotools entry: https://bio.tools/dexseq

@pavanvidem pavanvidem closed this Jan 31, 2025
@pavanvidem pavanvidem reopened this Jan 31, 2025
@bernt-matthias
Copy link
Contributor

technically, it should be an rds file because there is only one object in it.

You also use readRDS https://www.rdocumentation.org/packages/base/versions/3.6.2/topics/readRDS
Should be fine

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,7 +1,7 @@
<macros>
<token name="@TOOL_VERSION@">1.48.0</token>
<token name="@VERSION_SUFFIX@">0</token>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump.

I prefer bumbing all tools in a suite .. otherwise it becomes unmaintainable. Nobody checks if all tools use the macro on update...

@bgruening bgruening merged commit ed4091f into galaxyproject:main Jan 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants