Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to MVC5, new themes, refresh all packages #55

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

andrasfuchs
Copy link

New features in 2.5 (2015-03-30)

  • Upgraded the project file to work with Visual Studio 2013 Community Editon
  • The HTML structure of the site mirrors the default WordPress structure, so we can apply WordPress themes to FunnelWeb now
  • Theming engine now supports both WordPress and Bootstrap themes
  • Updated the MVC framework to version 5
  • Included Bootstrap 3 and it's responsive layout (so it's mobile-friendly now)
  • Redesigned the administration page
  • ShowDown and WMD is replaced by a more recent PageDown
  • The HTML is more HTML5-compliant
  • Tested with both SQL and SQL CE databases

Screenshots

Admin

admin-1
admin-2

WP-Flower theme

wp_flower-1
wp_flower-2
wp_flower-post-1
wp_flower-post-2
wp_flower-post-3
wp_flower-post-4

WP-Hostmarks theme

wp_hostmarks-1
wp_hostmarks-2
wp_hostmarks-post-1
wp_hostmarks-post-2
wp_hostmarks-post-3
wp_hostmarks-post-4

WP-Quark theme

wp_quark-1
wp_quark-2
wp_quark-post-1
wp_quark-post-2
wp_quark-post-3
wp_quark-post-4

WP-Topmag theme

wp_topmag-1
wp_topmag-2
wp_topmag-post-1
wp_topmag-post-2
wp_topmag-post-3
wp_topmag-post-4

Further Information

If you need some help with .NET, C#, MVC, Entity Framework, HTML5, CSS, JavaScript, jQuery or Bootstrap, you can contact me for one-on-one consultancy or live training on the Kevin Sharp Traning website.

noopman and others added 30 commits October 13, 2013 16:57
…till stores roles but they are mapped to claims in the app which does not use roles at all.
There was an invalid reference to the MVC dll in the test project.
In the WikiController's test class the constructor missed a
SettingsProvider parameter.
Admin header width changed to dynamic (previously it was 300px)
There is a condition where we check the DatabaseIssue property, but it
was check to be true where false is the proper value (in Login.cshtml)
Miniprofiler caused login page rendered in footer
New post field capitaization and displayname for selected tags
Fixed the blog entry width
ShowDown and WMD is replaced by PageDown (v2014-10-10)
Optical tuning of the new/edit post page
Fixed the radiobutton formatting
Updated the date to the standard HTML5 time tag
Added the HTML5 article and header tags for better SEO
Added bootstrap glyphs and modified the basic theme to show them before
and/or after the post summary
Fixed all links to images in themes
Upgraded jQuery to 2.1.3
Updated Disqus to use the web API and changed the way we get the number
of comments from Disqus. The display of the comment count was changed so
we have a uniform CSS styling for DB comments, Disqus comments and when
we have the comments disabled.
We have now a new field on the admin page to enter our Disqus API Key
The theme-engine was reworked to use WordPress themes. There are only 2
themes which look fine: hostmarks and quark.
There are now 4 WordPress themes which can be applied to FunnelWeb. The
old themes were removed.
Admin area was redesigned by applying a bootstrap theme on it.
Default CSS files were striped, the whole theme handling is clearer,
simpler then before.
Bootstrap 3.3.2 is also included now.
Minor design fixes in the admin area
Fixed the new grid system's CSS in a few pages
Small fixes around the themes, especially in the commenting area.
Markdown preview is now fixed on the comment partial view and the
admin/edit page too.
Tag editor is replaced with bootstrap tag editor, but the functionality
is disabled until the DB access layer is replaced by Entity Framework 6.
EnforcedString and PageName class explanation was added.
SQL CE database is included now. Also fixed a script error which
prevented creating the initial sql ce database. Added a script to add
the WordPress default entries on initialization.
Added a few screenshots of 4 wordpress themes to the docs folder
Fixed a small issue in flower theme
Updated version info to 2.5
@andrasfuchs andrasfuchs changed the title Upgrade to MVC4, new themes, refresh all packages Upgrade to MVC5, new themes, refresh all packages Mar 30, 2015
Added some info related to the updated version.
@JakeGinnivan
Copy link
Member

0_o

I think I should just add you and @noopman as colaborators of funnelweb?

@JakeGinnivan
Copy link
Member

Not that this isn't welcome, I am just not using FunnelWeb at the moment and you guys will likely do it justice helping maintain it?

@janierdavila
Copy link
Contributor

@andrasfuchs This is major! I see you have been busy! I will get these changes and see if I can integrate them with my blog branch to test it out.

@andrasfuchs
Copy link
Author

Thanks!

@JakeGinnivan Jake, sure, you can add me to the collaborators. This version needs to be tested and fixed here and there, but I hope others can join us!

@janierdavila Obviously I've made some breaking changes too, so please be careful with it :) I know that a few things are not working well, like the tagging control, sometimes I've got an NHibernate error while saving the settings etc., and I didn't have the time to test all the features (like Azure authentication).

On the other hand, I would be glad to get the some feedback or even fixes ;)

@JakeGinnivan
Copy link
Member

@andrasfuchs you have push access. You could push this to a branch in the main repo and get others to help out while it is stabilised

@andrasfuchs
Copy link
Author

@JakeGinnivan Great, thank you! I probably missed something, but I was unable to create a new branch in FunnelWeb. Could you double-check my settings or could you create a "mvc5-beta" branch for us?

@janierdavila
Copy link
Contributor

@andrasfuchs Have you tried this from your git console?:

git checkout -b mvc5-beta
...
git push origin mvc5-beta

@andrasfuchs
Copy link
Author

@janierdavila I'm clearly not a Git pro... Using your suggested checkout -b mvc5-beta command in the console, it created a branch in my/head repo (and not in the original/base).

According to this StackOverflow entry, you are right, that's the way to go: first I need to create a new branch in my (head) repo and then create a new pull request and then push it into a new branch at the base repo.

BUT, this is what I get when I'm trying to pull it into the master (looks OK):
image

and this is when I enter the "mvc5-beta" as the destination branch:
image

@janierdavila
Copy link
Contributor

@andrasfuchs Since you have push access now, I was thinking you could just push that new branch to this repo instead of your fork.

You can try these steps to add this repo to your list of remotes and push directly.

git remote add base https://github.com/funnelweblog/FunnelWeb.git
git push base mvc5-beta

Let me know if that works

@JakeGinnivan
Copy link
Member

Hey @andrasfuchs

What you want is to have two remotes, upstream and origin. Or base as @andrasfuchs, I use upstream but either way origin should point to your fork.

To get yourself where you need to be do this

git fetch upstream
git branch mvc5-beta                # create but do not checkout the branch
git reset --hard upstream/master     # this will make your master branch in sync with upstream
git checkout mvc5-beta         # try to always work on a feature branch
git push upstream mvc5-beta

A mvc5-beta branch will then exist in the main repo. You don't do this via a pull request, you push with the last command above. Once it is in the main repo you can close this PR and open a new one between the mvc5-beta branch and master

@JakeGinnivan
Copy link
Member

I think you just need the last command tbh, but resetting your master to not have this stuff on it is a good idea as it will stop accidental pushes of this code into master before you are ready

@andrasfuchs
Copy link
Author

Thanks for the tips guys!

My default upstream is not the original FunnelWeb repo, but noopman's fork. I had to add the original repo as a named remote, but it seemed to work.

image

When I tried the git reset --hard upstreamFW/master I got a fatal error telling me that unknown revision or path not in the working tree.

Nonetheless I continued to run the git push upstreamFW mvc5-beta and I got back permission denied error.

@JakeGinnivan could you double-check my access rights?

@JakeGinnivan
Copy link
Member

You need to do a fetch before the reset, simply adding the remote is not enough.

I added you to a team, but didn't add the team to the repo. You should have access now

@andrasfuchs
Copy link
Author

Looks good, the source is in the mvc5-beta branch now, thanks!

@andrasfuchs
Copy link
Author

@janierdavila I disabled MiniProfiler (in _Public.cshtml and _Private.cshtml) when I started to work with FunnelWeb, I'm not sure if it works now if you put it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants