Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : company field required for multi company setup #45415

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

meera-greycube
Copy link

@meera-greycube meera-greycube commented Jan 24, 2025

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

feat : company field required for multi company setup
@meera-greycube meera-greycube changed the title Update vehicle.json feat : company field required for multi company setup Jan 24, 2025
@@ -1,6 +1,5 @@
{
"actions": [],
"allow_rename": 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove the allow_rename property?

"print": 1,
"read": 1,
"report": 1,
"role": "Delivery User"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for removing these permissions?

Copy link
Member

@nabinhait nabinhait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use semantic commits
  • Write description of the changes

@nabinhait nabinhait self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants