Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: configurable posting date for Exc Gain / Loss journal (backport #44790) #45399

Merged
merged 8 commits into from
Jan 23, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 23, 2025

Issue

Consider a situation were the payment and invoice are both in locked period. If it is a forex transaction and if they incur any exchange gain / loss, system tries to create a Journal in the payment date to capture that gain / loss. This will fail due to the period being locked.

| Oct (Locked) | Nov (Locked) | Dec            |
|--------------+--------------+----------------|
| Payment      | Invoice      | Reconciliation |

Configurable Exchange Gain / Loss posting date (Only applies for Normal Payments)

Screenshot from 2025-01-23 16-23-00

todo:

  • patch to set default config value
  • Test cases
  • Support Gain / Loss JE posting date configuration in Semi-Auto Reconciliation tool

ref: https://support.frappe.io/helpdesk/tickets/28039


This is an automatic backport of pull request #44790 done by Mergify.

patch to update default value

(cherry picked from commit b2c3da1)
(cherry picked from commit a717188)

# Conflicts:
#	erpnext/accounts/doctype/process_payment_reconciliation_log_allocations/process_payment_reconciliation_log_allocations.json
Copy link
Contributor Author

mergify bot commented Jan 23, 2025

Cherry-pick of a717188 has failed:

On branch mergify/bp/version-15-hotfix/pr-44790
Your branch is ahead of 'origin/version-15-hotfix' by 5 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit a71718883e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/accounts/doctype/process_payment_reconciliation_log_allocations/process_payment_reconciliation_log_allocations.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/doctype/process_payment_reconciliation_log_allocations/process_payment_reconciliation_log_allocations.json

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ruthra-kumar ruthra-kumar force-pushed the mergify/bp/version-15-hotfix/pr-44790 branch from a1aefca to 3906e5c Compare January 23, 2025 11:36
@ruthra-kumar ruthra-kumar merged commit 7fdf2a7 into version-15-hotfix Jan 23, 2025
11 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-15-hotfix/pr-44790 branch January 23, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant