feat: solution for issue 43048 - applying multiple margin pricing rules #45165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didiman1998
requested review from
ruthra-kumar and
rohitwaghchaure
as code owners
Didiman1998
changed the title
Didiman1998
changed the title
Didiman1998
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone :),
we have created an issue with ERPNext, where we describe a problem with the calculation of multiple pricing rules in ERPNext.
#43048
To see and understand the problem in its details, please look at the issue and take a look at the video i made for that. :)!
Therefore with this pull request we have already implemented a solution for that problem, which keeps the old functionality but also calculates now the right amounts with multiple pricing rules.
We have also made a video, where we show how our solution works. :) So please watch the video if you want to know more.
Thank you guys for considering this pull request and if you need anything, you can let me know.
Please backport to v15 and v14 if possible!
Best Regards
Dietmar
2025-01-07.07-56-22.mp4