Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if tds deducted based on Purchase Taxes and Charges #45161

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ljain112
Copy link
Contributor

@ljain112 ljain112 commented Jan 8, 2025

Issue: When an account is changed in a Tax withholding account in the middle of period, Tax Deducted at Source (TDS) is deducted on all invoices, including those on which TDS has already been deducted.

Steps to Replicate:

  • Create a Tax Withholding Category with a limit of 10,000 and rate = 10%.
  • Create a supplier with the same Tax Withholding Category.
  • Create a Purchase Invoice with an amount of ₹15,000. The expected TDS is ₹1,500 (calculated as ₹15,000 * 10%).
  • Change the TDS Account in the Tax Withholding Category.
  • Create another Purchase Invoice with an amount of ₹10,000.

The TDS for the second invoice should be ₹1,000 (calculated as ₹10,000 * 10%). However, due to the current system logic, TDS is recalculated based on the new account change, resulting in a total deduction of ₹2,500 (calculated as (₹15,000 + ₹10,000) * 10%).

Proposed Solution:

  • Utilize the "is_tax_withholding_account" checkbox in the Purchase Taxes and Charges table to determine if TDS has already been deducted.

Note: This field is only available in Purchase Taxes and Charges Table

Frappe Support Issue:
https://support.frappe.io/app/hd-ticket/28665
https://support.frappe.io/app/hd-ticket/28660

backport-version-14
backport-version-15

@ljain112 ljain112 requested a review from ruthra-kumar as a code owner January 8, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant