fix: update fields on change of item code In Update Items of Sales Order
#45125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanket322
changed the title
Sanket322
changed the title
Update Items of Sales Order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Support Ticket - 28625
Depends on Frappe Fix : Currently, this.doc is not updating correctly after one update.
As Shown in screenshot on change of 3rd row this.doc contains value for last row that was added.
What This PR Does
This PR addresses the support issue of updating the rate and other fields if they are already set for the items, but due to a Frappe bug where doc.idx does not update correctly for multiple rows, the functionality currently works for a single row only. Once the Frappe fix is implemented, it will work perfectly for all rows.
Additionally, due to this same bug, the UOM update functionality, which is already written, is also not functioning correctly for multiple rows.