-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: screenshot workflows #1183
Conversation
Reviewer's Guide by SourceryThis pull request addresses issues with the screenshot workflows by adding git configuration for the github-actions bot. Sequence diagram for screenshot workflow with git configurationsequenceDiagram
participant GH as GitHub Actions
participant Android as Android Screenshot Action
participant iOS as iOS Screenshot Action
participant Git as Git Repository
alt Android Screenshot Workflow
GH->>Android: Trigger screenshot action
Android->>Android: Configure git user/email
Android->>Git: Clone fastlane-android branch
Android->>Git: Perform screenshot tasks
end
alt iOS Screenshot Workflow
GH->>iOS: Trigger screenshot action
iOS->>iOS: Configure git user/email
iOS->>Git: Clone fastlane-ios branch
iOS->>Git: Perform screenshot tasks
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please expand the PR description to explain what issues were occurring with the screenshot workflows and how adding the git configuration fixes them. This context will be helpful for future reference.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build successful. APKs to test: https://github.com/fossasia/badgemagic-app/actions/runs/13071263448/artifacts/2516227079 |
Fixes the screenshot workflows.
Summary by Sourcery
CI: