feat(engines): removed linting and badge addition in favor of js-scaf…

…folder behavior also broadened the engines range BREAKING CHANGE: retaining the addition of a node version requirement badge and linting requires use with js-scaffolder >=14.12.0
form8ion · Nov 23, 2021 · ca7e874 · ca7e874
1 parent 30ac2fa
commit ca7e874
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 45 deletions.
diff --git a/package.json b/package.json
@@ -76,6 +76,6 @@
     "mustache": "^4.0.0"
   },
   "peerDependencies": {
-    "@travi/javascript-scaffolder": "^10.18.0 || ^11.0.0-alpha.1 || ^12.0.0 || ^13.0.0 || ^14.0.0"
+    "@travi/javascript-scaffolder": "^14.12.0"
   }
 }
diff --git a/src/testing-test.js b/src/testing-test.js
@@ -11,7 +11,6 @@ suite('testing', () => {
   let sandbox;
   const projectRoot = any.string();
   const pathToCreatedDirectory = any.string();
-  const packageName = any.word();
 
   setup(() => {
     sandbox = sinon.createSandbox();
@@ -38,23 +37,15 @@ suite('testing', () => {
         eslintConfigs: cucumberEslintConfigs
       });
 
-    const results = await scaffoldTesting({projectRoot, packageName, tests: {integration: true}});
+    const results = await scaffoldTesting({projectRoot, tests: {integration: true}});
 
     assert.deepEqual(
       results,
       {
-        scripts: {'lint:engines': 'check-engine', ...cucumberScripts},
-        devDependencies: ['check-engine', '@travi/any', 'http-status-codes', ...cucumberDevDependencies],
+        scripts: cucumberScripts,
+        devDependencies: ['@travi/any', 'http-status-codes', ...cucumberDevDependencies],
         eslintConfigs: cucumberEslintConfigs,
-        packageProperties: {engines: {node: '12.x.x'}},
-        badges: {
-          consumer: {
-            node: {
-              img: `https://img.shields.io/node/v/${packageName}.svg`,
-              text: 'node'
-            }
-          }
-        }
+        packageProperties: {engines: {node: '>=12'}}
       }
     );
     assert.calledWith(
@@ -70,24 +61,9 @@ suite('testing', () => {
   });
 
   test('that no canary test is created when the project will not be integration tested', async () => {
-    const results = await scaffoldTesting({tests: {integration: false}, packageName});
+    const results = await scaffoldTesting({tests: {integration: false}});
 
-    assert.deepEqual(
-      results,
-      {
-        devDependencies: ['check-engine'],
-        packageProperties: {engines: {node: '12.x.x'}},
-        scripts: {'lint:engines': 'check-engine'},
-        badges: {
-          consumer: {
-            node: {
-              img: `https://img.shields.io/node/v/${packageName}.svg`,
-              text: 'node'
-            }
-          }
-        }
-      }
-    );
+    assert.deepEqual(results, {packageProperties: {engines: {node: '>=12'}}});
     assert.notCalled(mkdir.default);
     assert.notCalled(promises.copyFile);
   });

diff --git a/src/testing.js b/src/testing.js
@@ -4,20 +4,8 @@ import deepmerge from 'deepmerge';
 import {scaffold as scaffoldCucumber} from '@form8ion/cucumber-scaffolder';
 import mkdir from '../thirdparty-wrappers/make-dir';
 
-export default async function ({projectRoot, packageName, tests}) {
-  const commonResults = {
-    devDependencies: ['check-engine'],
-    scripts: {'lint:engines': 'check-engine'},
-    badges: {
-      consumer: {
-        node: {
-          img: `https://img.shields.io/node/v/${packageName}.svg`,
-          text: 'node'
-        }
-      }
-    },
-    packageProperties: {engines: {node: '12.x.x'}}
-  };
+export default async function ({projectRoot, tests}) {
+  const commonResults = {packageProperties: {engines: {node: '>=12'}}};
 
   if (tests.integration) {
     const [stepDefinitionsDirectory, cucumberResults] = await Promise.all([