Allow custom Content-Disposition filename in #create_temp_url method #452
Conversation
|
Build succeeded.
|
|
@vala, LGTM. Any chance you could add some tests? Obviously we inherited disjointed tests but we've got to progressively fill up the blanks. |
| temp_url_options = { | ||
| :scheme => scheme, | ||
| :host => host, | ||
| :port => port, | ||
| :path => object_path_escaped, | ||
| :query => "temp_url_sig=#{sig}&temp_url_expires=#{expires}" | ||
| :query => "temp_url_sig=#{sig}&temp_url_expires=#{expires}&filename=#{filename}" |
There was a problem hiding this comment.
Filename needs to be filtered out if the parameter is empty.
|
Actually the option need to be filtered if empty, please see inline. |
|
Why do we need to filter that param out ? On my Swift instance, if the filename is empty ( Isn't that your case ? |
|
Isn't this fixed here ? |
|
I'm sorry for the delay, there's a conflict now. I think this is no longer relevant as the query can contain multiple keys. Please let me know if I'm missing something, otherwise I think we can now close the PR. |
|
Closing now, please reopen if I missed anything. |
Hi there,
To follow up on #338 I added the support for custom file names in Swift's temp url generation method
Fog::OpenStack::Storage::Real#create_temp_url.I found no tests for the
#create_temp_urlmethod so I did not write any.Note that the param is always passed, even when the
:filenameoption isn't provided since the Swift service will simply use the last member of the path as the content disposition filename by default, even if thefilename=param is passed an empty value.