Fix specs #76
Merged
Fix specs #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cancelling other tests when older versions of Ruby are being tested often results in wasting time restarting them so this changes it so everything should run and complete so we get an accurate picture of the failing versions.
tokengeek
force-pushed
the
fix_specs
branch
2 times, most recently
from
e7005cc to
b203114
Compare
This formerly was getting pulled in implicitly from other sources but some upstream changes result in this complaining that the top level module was not found. This requires resolves that.
Upstream in `fog-core` the method was inverted to use `select` rather than a negated reject for Rubocop style rules. That caused this spec to fail as only `reject` was stubbed. This stubs `select` as well so this should work for both versions, older versions of `fog-core` and newer ones.
These authentication examples stopped matching has the `Host` headers included the port, which changes by default in Excon v1.0. Removing the examples allows the tests to pass with the latest versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to account for upstream changes causing specs to error/fail.