testsuite: fix flaky test in t0019-tbon-config.t #6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The test `tbon.endpoint cannot be set` in t0019-tbon-config.t fails occasionally in ci because the `flux start` command reports it is terminated by SIGPIPE rather than SIGKILL/SIGTERM. The test is just meant to detect an expected failure of the command, it does not matter how the command fails. Just use `!` to detect failure. Add a note to explain why `test_must_fail` or similar is not used here. Fixes flux-framework#6336
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6563 +/- ##
=======================================
Coverage 79.44% 79.44%
=======================================
Files 531 531
Lines 88247 88247
=======================================
+ Hits 70110 70112 +2
+ Misses 18137 18135 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The test
tbon.endpoint cannot be setin t0019-tbon-config.t fails occasionally in ci because theflux startcommand reports it is terminated by SIGPIPE rather than SIGKILL/SIGTERM.The test is just meant to detect an expected failure of the command, it does not matter how the command fails. Just use
!to detect failure. Add a note to explain whytest_must_failor similar is not used here.Fixes #6336