feat: Add support for reload_after, sniffer_class_name es output parameters #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meters Signed-off-by: penekk <[email protected]>
penekk
force-pushed
the
add-fluentd-elasticsearch-parameters
branch
from
0c0d983 to
68171fe
Compare
|
I am affected as well, merging this is appreciated. |
wenchajun
approved these changes
Feb 7, 2025
|
Great, thanks for contributing! |
|
@wenchajun now that I'm thinking - I probly should've bumped versions like here penekk@936f49e right? and then prep a sync commit in helm-charts. The only downside I see is that the default version of used operator image would not match what we can configure with updated chart at that point (I planned to pull the operator image by SHA for the time being). Any preferences on how to sort it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
CRDs in current form and operator itself lack support for
reload_afterandsniffer_class_nameelasticsearch output parameters.Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: