Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rdkafka gem installation to Dockerfiles for fluent-watcher #1415

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

MioOgbeni
Copy link
Contributor

What this PR does / why we need it:

Hi, I want to use Kafka FluentD plugin, but the base library ruby-kafka is deprecated, which is also not compatible with my Strimzi Kafka installation. Then I tried to use the new rdkafka part of this plugin, but it fails with the fluent-operator image because it needs to have the C rdkafka library installed as well. I tried to create my own image, but now I want to publish this fix for all users.

Which issue(s) this PR fixes:

None

Does this PR introduced a user-facing change?

- rdkafka part of fluent-plugin-kafka can be now used with fluent-operator FluentD image.

Additional documentation, usage docs, etc.:


@MioOgbeni
Copy link
Contributor Author

Now I think everything is ready for review.

I had to add some dependencies that the rdkafka library requires during the build. All these dependencies are only in build-deps, and are removed at the end.

I also tested it from the same Dockerfile on my environment, but only for the amd64 image. Currently I am not able to run also arm64 machines for proper testing. In a few months I will have arm64 machines available and will need the Kafka plugin on them as well, so I would possibly make a fix then.

@MioOgbeni MioOgbeni marked this pull request as ready for review November 21, 2024 14:30
@MioOgbeni
Copy link
Contributor Author

Force pushed only due to forgotten commit sign-off ;)

@benjaminhuo benjaminhuo merged commit 92df045 into fluent:master Nov 26, 2024
6 checks passed
@benjaminhuo
Copy link
Member

@MioOgbeni Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants