-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log to metrics plugin #1305
Add log to metrics plugin #1305
Conversation
a122fc4
to
98b000a
Compare
@cosmo0920 the build is failing for some other reason. I have raised PR so that we can get started with the discussions. Meanwhile i will try to look at the build issue. Also running make is actually modifying some other files dont know why. Would need your help in this part. Do we need to add tests for this plugin? |
98b000a
to
c486362
Compare
fc28e76
to
3d64acc
Compare
@benjaminhuo Now the local build is working. I guess make is autoformatting the code and wantedly changing modified: apis/fluentbit/v1alpha2/plugins/filter/zz_generated.deepcopy.go
modified: apis/fluentbit/v1alpha2/zz_generated.deepcopy.go
modified: go.mod
modified: go.sum Not sure why. I removed those changes and then pushed it for now |
@benjaminhuo push to ghcr seems to fail (403 error code). I guess thats issue with some configuration in gcp i guess. Does this seem fine now? |
@cosmo0920 Could you check the PR? i have addressed your comments |
The auto-generated files shouldn't be removed. |
Ok fine |
0bc2819
@benjaminhuo Have added them too as well |
I put an approve and kicked CI tasks as well. |
@cosmo0920 seems like its passing the tests. Anything else i missed? |
Signed-off-by: Athish Pranav D <[email protected]>
Signed-off-by: Athish Pranav D <[email protected]>
38a2605
0bc2819
to
38a2605
Compare
@benjaminhuo addressed your comments. I wasnt sure about the convention part that you guys followed |
Thanks for the contribution! @Athishpranav2003 |
What this PR does / why we need it:
Add
LogToMetrics
Filter pluginWhich issue(s) this PR fixes:
Fixes #1285
Does this PR introduced a user-facing change?
Nope
Additional documentation, usage docs, etc.:
Updated in the codebase itself.