Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the ordering of returns on get_grid_point #841

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes the ordering of returns on get_grid_point #841

wants to merge 2 commits into from

Conversation

WillJRoper
Copy link
Collaborator

@WillJRoper WillJRoper commented Feb 14, 2025 •
edited
Loading

Closes #840.

Now get_grid_point maintains the axis order and also warns if the user passed unrecognised grid axes.

Issue Type

  • Bug

Checklist

  • I have read the CONTRIBUTING.md -->
  • I have added docstrings to all methods
  • I have added sufficient comments to all lines
  • I have made corresponding changes to the documentation
  • My changes generate no pep8 errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@WillJRoper WillJRoper added bug Something isn't working grid Any issues pertaining to grids labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmwilkins stephenmwilkins Awaiting requested review from stephenmwilkins

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working grid Any issues pertaining to grids
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undesirable grid.get_grid_point() behaviour
1 participant
@WillJRoper