Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undesirable grid.get_grid_point() behaviour #840

Open
stephenmwilkins opened this issue Feb 14, 2025 · 1 comment · May be fixed by #841
Open

undesirable grid.get_grid_point() behaviour #840

stephenmwilkins opened this issue Feb 14, 2025 · 1 comment · May be fixed by #841
Assignees
Labels
grid Any issues pertaining to grids

Comments

@stephenmwilkins
Copy link
Collaborator

grid.get_grid_point returns the closest grid point as a tuple for a specified set of values given as keyword arguments, e.g.
grid.get_grid_point(metallicity=0.01, log10age=6.)

However, the ordering of the returned tuple matches the ordering of the arguments not the actual grid axes. IMO it would be better to always return in the order of grid axes, not the ordering of the keywords.

@WillJRoper
Copy link
Collaborator

Good point, simple fix too.

@WillJRoper WillJRoper added the grid Any issues pertaining to grids label Feb 14, 2025
@WillJRoper WillJRoper self-assigned this Feb 14, 2025
@WillJRoper WillJRoper linked a pull request Feb 14, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid Any issues pertaining to grids
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants