Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 404 status code in the proxyResponse. #8119

Merged
merged 6 commits into from
Jan 31, 2025
Merged

Handle 404 status code in the proxyResponse. #8119

merged 6 commits into from
Jan 31, 2025

Conversation

chalosalvador
Copy link
Member

@chalosalvador chalosalvador commented Jan 15, 2025 •
edited
Loading

Description

Fixes #8035 by correctly handling 404 status code in the proxyResponse.

Scenarios Tested

  1. Initialize a Next.js project with Firebase hosting.
  2. Start the emulators
  3. Go to a non-existent page. The Next.js custom 404 page is rendered.

@chalosalvador chalosalvador self-assigned this Jan 15, 2025
leoortizz
leoortizz approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@leoortizz leoortizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just add the changelog and we can merge, thanks!

@chalosalvador chalosalvador enabled auto-merge (squash) January 31, 2025 09:21
@chalosalvador chalosalvador merged commit 60f3cd7 into master Jan 31, 2025
41 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoortizz leoortizz leoortizz approved these changes

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

Assignees

@chalosalvador chalosalvador

Labels
integration: web frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webframeworks experiment 404 handling incorrect
2 participants
@chalosalvador @leoortizz