Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding better error messaging when using non Firebase projects #8021

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Dec 3, 2024

Description

Adding better error messaging when using projects that do not have Firebase enabled.

@joehan joehan requested a review from rachelsaunders December 3, 2024 17:59
src/command.ts Outdated Show resolved Hide resolved
src/commands/deploy.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated
/**
* Create a Migrate to Firebase Console URL for the specified project.
*/
export function migrateToFirebaseLink(project: string): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have flexibility on this verb "migrate"? It's not really a "migrate to Firebase" but more like "add Firebase" if that's possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely - I took 'migrate' from the query parameter in the console link, but if 'add Firebase' is more accurate lets use that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, from the dev perspective, it's messaged as "add Firebase"

e.g., https://firebase.google.com/docs/reference/firebase-management/rest/v1beta1/projects/addFirebase

joehan and others added 3 commits December 3, 2024 10:10
src/utils.ts Outdated
/**
* Create a Migrate to Firebase Console URL for the specified project.
*/
export function migrateToFirebaseLink(project: string): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, from the dev perspective, it's messaged as "add Firebase"

e.g., https://firebase.google.com/docs/reference/firebase-management/rest/v1beta1/projects/addFirebase

@joehan joehan enabled auto-merge (squash) January 8, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants