-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding better error messaging when using non Firebase projects #8021
base: master
Are you sure you want to change the base?
Conversation
src/utils.ts
Outdated
/** | ||
* Create a Migrate to Firebase Console URL for the specified project. | ||
*/ | ||
export function migrateToFirebaseLink(project: string): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have flexibility on this verb "migrate"? It's not really a "migrate to Firebase" but more like "add Firebase" if that's possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely - I took 'migrate' from the query parameter in the console link, but if 'add Firebase' is more accurate lets use that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, from the dev perspective, it's messaged as "add Firebase"
e.g., https://firebase.google.com/docs/reference/firebase-management/rest/v1beta1/projects/addFirebase
Co-authored-by: rachelsaunders <[email protected]>
Co-authored-by: rachelsaunders <[email protected]>
src/utils.ts
Outdated
/** | ||
* Create a Migrate to Firebase Console URL for the specified project. | ||
*/ | ||
export function migrateToFirebaseLink(project: string): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, from the dev perspective, it's messaged as "add Firebase"
e.g., https://firebase.google.com/docs/reference/firebase-management/rest/v1beta1/projects/addFirebase
Description
Adding better error messaging when using projects that do not have Firebase enabled.