Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Hosting Emulator: Init #7937

Merged
merged 25 commits into from
Nov 20, 2024
Merged

App Hosting Emulator: Init #7937

merged 25 commits into from
Nov 20, 2024

Conversation

mathu97
Copy link
Contributor

@mathu97 mathu97 commented Nov 12, 2024

Properly initialize the App Hosting emulator when app hosting emulator is selected during firebase init emulators.

When the app hosting emulator is initialized ...

  1. user should be prompted for root directory and rootDirectory config should be set
  2. the default start command should be detected and startCommandOverride should be set
  3. user should be prompted to export secrets

Additionally ...

  • Refactored logic used by apphosting:config:export command so that it can be re-used at init.
  • Added scaffolding to make it easy for emulators to add additional prompts when init emulators is ran.

@mathu97 mathu97 force-pushed the apphosting-emulator/init branch from d61e180 to d0e2cba Compare November 14, 2024 16:14
@mathu97 mathu97 requested review from joehan and taeold November 19, 2024 15:45
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitty things, but lgtm after some small fixes.

src/apphosting/config.ts Outdated Show resolved Hide resolved
src/apphosting/config.ts Outdated Show resolved Hide resolved
src/apphosting/config.ts Outdated Show resolved Hide resolved
src/emulator/apphosting/utils.ts Outdated Show resolved Hide resolved
src/emulator/initEmulators.ts Outdated Show resolved Hide resolved
src/apphosting/config.ts Show resolved Hide resolved
src/emulator/apphosting/serve.ts Outdated Show resolved Hide resolved
src/apphosting/config.ts Outdated Show resolved Hide resolved
src/apphosting/config.ts Outdated Show resolved Hide resolved
src/apphosting/config.ts Show resolved Hide resolved
src/apphosting/config.ts Show resolved Hide resolved
src/apphosting/config.ts Outdated Show resolved Hide resolved
src/apphosting/config.ts Outdated Show resolved Hide resolved
src/apphosting/config.ts Show resolved Hide resolved
src/emulator/apphosting/utils.ts Outdated Show resolved Hide resolved
@mathu97 mathu97 enabled auto-merge (squash) November 20, 2024 03:10
@mathu97 mathu97 merged commit d19be77 into master Nov 20, 2024
45 checks passed
@mathu97 mathu97 deleted the apphosting-emulator/init branch November 20, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants